fix index check on trygetvalue - #109
Merged
Merged
Conversation
to11mtm
commented
Feb 8, 2026
| //Shouldn't happen much and only on startup... | ||
| var f = _formatters; | ||
| if (i > f.Length) | ||
| if (i >= f.Length) |
Member
Author
There was a problem hiding this comment.
We are going to index into an array based on this check...
I am somewhat surprised that we haven't seen this come up as an issue filed on the lib...
That said there are possibly times where this could result in transient failures; i.e. if you had 257 types, it's possible the 256'th would transiently fail, but once the 257'th got loaded, the 256th type would be good to go again...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes an index check on
IntIndexedMessagePackFormatterDictto avoid a potential Index out of range exceptionChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):